Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/datadog #9026: Make thresholds optional. #10526

Merged
merged 1 commit into from
Dec 5, 2016
Merged

provider/datadog #9026: Make thresholds optional. #10526

merged 1 commit into from
Dec 5, 2016

Conversation

ojongerius
Copy link
Contributor

No description provided.

@ojongerius ojongerius mentioned this pull request Dec 5, 2016
Closed
@stack72
Copy link
Contributor

stack72 commented Dec 5, 2016

Hi @ojongerius

Thanks for the work here - this LGTM! test results as follows

% make testacc TEST=./builtin/providers/datadog
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/12/05 09:43:25 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/datadog -v  -timeout 120m
=== RUN   TestDatadogMonitor_import
--- PASS: TestDatadogMonitor_import (81.49s)
=== RUN   TestProvider
--- PASS: TestProvider (0.00s)
=== RUN   TestProvider_impl
--- PASS: TestProvider_impl (0.00s)
=== RUN   TestAccDatadogMonitor_Basic
--- PASS: TestAccDatadogMonitor_Basic (79.32s)
=== RUN   TestAccDatadogMonitor_BasicNoTreshold
--- PASS: TestAccDatadogMonitor_BasicNoTreshold (78.31s)
=== RUN   TestAccDatadogMonitor_Updated
--- PASS: TestAccDatadogMonitor_Updated (63.03s)
=== RUN   TestAccDatadogMonitor_TrimWhitespace
--- PASS: TestAccDatadogMonitor_TrimWhitespace (71.38s)
=== RUN   TestAccDatadogMonitor_Basic_float_int
--- PASS: TestAccDatadogMonitor_Basic_float_int (75.71s)
=== RUN   TestAccDatadogTimeboard_update
--- PASS: TestAccDatadogTimeboard_update (75.21s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/datadog	524.466s

Paul

@stack72 stack72 merged commit 5a4578e into hashicorp:master Dec 5, 2016
gusmat pushed a commit to gusmat/terraform that referenced this pull request Dec 6, 2016
@ojongerius
provider/datadog hashicorp#9026: Make thresholds optional. (hashicorp…
0e16dbf 
…#10526)
@ojongerius ojongerius deleted the 9026_thresholds_not_required branch December 12, 2016 01:34
@ghost
Copy link

ghost commented Apr 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ojongerius @stack72